feat: decouple read FeedId from inbound MailboxId
Separate the two feed identities so the public read URL never reveals the inbound address and vice-versa: - FeedId becomes an opaque high-entropy token (read id + KV key); MailboxId (noun.noun.NN) owns the inbound address and the untrusted-input boundary via MailboxId.parse. They map only through the inbound:<mailbox> secondary index, resolved solely at reception. - inbound index lifecycle is owned by FeedRepository: written by save/saveConfig, dropped by removeFromList(Bulk) — symmetric, never mirrored by hand (removes the manual delete in feed-service + the cron loop, and a silent empty-catch). - Feed.mailboxId exposes a MailboxId VO (symmetry with Feed.id); the mailbox@domain shape lives on MailboxId.emailAddress(domain). - Distinguish mailbox_unknown (no feed claims the address) from feed_not_found (dangling index) for observability; both forwardable, both 404. - Drop the redundant EmailParser.extractMailbox pass-through so MailboxId.parse is the single parse boundary. Docs (README/INSTALL/CLAUDE.md/landing) and tests updated; 439 tests green, tsc clean, build dry-run OK. Co-Authored-By: Claude Opus 4.7 <[email protected]>
This commit is contained in:
1 parent
f7f10779bc
commit
1a4a479190
43 files changed
+649
-149
No files matched your search
@@ -1,7 +1,7 @@
|
||||
import { describe, it, expect, beforeEach } from "vitest";
|
||||
import { http, HttpResponse } from "msw";
|
||||
import worker from "../index";
|
||||
import { server, createMockEnv, MockR2 } from "../test/setup";
|
||||
import { server, createMockEnv, MockR2, seedInboundIndex } from "../test/setup";
|
||||
import type { Env } from "../types";
|
||||
import type { ForwardEmailPayload } from "../infrastructure/forwardemail";
|
||||
|
||||
@@ -64,6 +64,7 @@ describe("POST /api/inbound — IP middleware", () => {
|
||||
`feed:${VALID_FEED_ID}:config`,
|
||||
JSON.stringify({ allowed_senders: [] }),
|
||||
);
|
||||
await seedInboundIndex(env, VALID_FEED_ID);
|
||||
});
|
||||
|
||||
it("returns 401 when IP is not in the ForwardEmail allowlist", async () => {
|
||||
@@ -99,9 +100,10 @@ describe("POST /api/inbound — IP middleware", () => {
|
||||
describe("POST /api/inbound — handler logic", () => {
|
||||
let env: Env;
|
||||
|
||||
beforeEach(() => {
|
||||
beforeEach(async () => {
|
||||
stubForwardEmailIps();
|
||||
env = createMockEnv() as unknown as Env;
|
||||
await seedInboundIndex(env, VALID_FEED_ID);
|
||||
});
|
||||
|
||||
it("returns 500 on malformed JSON body", async () => {
|
||||
@@ -232,9 +234,10 @@ describe("POST /api/inbound — handler logic", () => {
|
||||
describe("POST /api/inbound — attachment upload", () => {
|
||||
let env: Env;
|
||||
|
||||
beforeEach(() => {
|
||||
beforeEach(async () => {
|
||||
stubForwardEmailIps();
|
||||
env = createMockEnv({ withR2: true }) as unknown as Env;
|
||||
await seedInboundIndex(env, VALID_FEED_ID);
|
||||
});
|
||||
|
||||
it("uploads attachments to R2 and records ids in metadata", async () => {
|
||||
|
||||
Reference in new issue
Block a user